Add java API to create cluster with CloudConfig#647
Merged
junkaixue merged 1 commit intoapache:helix-cloudfrom Jan 6, 2020
Merged
Add java API to create cluster with CloudConfig#647junkaixue merged 1 commit intoapache:helix-cloudfrom
junkaixue merged 1 commit intoapache:helix-cloudfrom
Conversation
013652e to
6ee0621
Compare
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
Outdated
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
d3ec23b to
6717640
Compare
zhangmeng916
approved these changes
Dec 13, 2019
jiajunwang
reviewed
Dec 17, 2019
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
jiajunwang
reviewed
Dec 19, 2019
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
5940a23 to
2a3aa37
Compare
junkaixue
reviewed
Jan 2, 2020
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
cc10eeb to
a4f1bbd
Compare
a4f1bbd to
0af8769
Compare
junkaixue
approved these changes
Jan 6, 2020
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Leave some minor comments. Overall, LGTM. Make sure you resolve other review comments.
helix-core/src/main/java/org/apache/helix/SystemPropertyKeys.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
In this commit the below APIs have been added. 1- AddCluster with CloudCOnfig API. 2- addCloudConfig to existing cluster. 3- Update CloudConfig to update existing Cloud Config. Several tests have been added to test these APIs.
30cd8b2 to
7bf99c1
Compare
Author
|
This PR is ready to be merged, approved by @zhangmeng916 and @dasahcc. Final Commit message: Body: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes TODO: Add relevant java Level APIs for cloudConfig creation #646.
Description
In this commit the below APIs have been added.
1- AddCluster with CloudCOnfig API.
2- addCloudConfig to existing cluster.
3- Update CloudConfig to update existing Cloud Config
Several tests have been added to validate these APIs.
Tests
New tests have been added.
TestConfigAccessor.testUpdateCloudConfig
TestZkHelixAdmin.testAddCloudConfig
TestClusterSetup.testAddClusterWithInvalidCloudConfig
TestClusterSetup.testAddClusterWithValidCloudConfig
TestClusterSetup.testAddClusterAzureProvider
Test Result 1: mvn test
[INFO] Tests run: 900, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,228.171 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 900, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53:52 min
[INFO] Finished at: 2019-12-09T13:52:08-08:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality