Skip to content

Add DedicatedZkClient and update DedicatedZkClientFactory #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
narendly merged 14 commits into from
Feb 21, 2020
Merged

Add DedicatedZkClient and update DedicatedZkClientFactory #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b266182
WIP: Add DedicatedZkClient and update DedicatedZkClientFactory
narendly Feb 14, 2020
9c86d1d
Add Javadoc
narendly Feb 15, 2020
673a975
Fix
narendly Feb 16, 2020
bcff9fc
Add MetadataStoreRoutingData temporarily
narendly Feb 18, 2020
b132cf3
Add tests
narendly Feb 19, 2020
19326d3
Just do a sharding key check
narendly Feb 19, 2020
c219526
Update and address comments
narendly Feb 19, 2020
29a16eb
Add Javadoc
narendly Feb 19, 2020
9629737
address comments
narendly Feb 20, 2020
ad1d251
Update tests
narendly Feb 20, 2020
7345f8a
Update
narendly Feb 20, 2020
c4535ed
asdf
narendly Feb 20, 2020
16940e2
Fix'
narendly Feb 20, 2020
f8ed4a6
Rebase onto apache zooscalability
narendly Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions zookeeper-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ under the License.
<artifactId>metrics-common</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.helix</groupId>
<artifactId>metadata-store-directory-common</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
Expand Down Expand Up @@ -79,6 +84,12 @@ under the License.
<artifactId>testng</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.6</version>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<resources>
Expand Down
16 changes: 13 additions & 3 deletions ...r-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
* under the License.
*/

import org.apache.helix.msdcommon.datamodel.MetadataStoreRoutingData;
import org.apache.helix.zookeeper.api.client.RealmAwareZkClient;


Expand All @@ -30,16 +31,25 @@ public interface RealmAwareZkClientFactory {
* Build a RealmAwareZkClient using specified connection config and client config.
* @param connectionConfig
* @param clientConfig
* @param metadataStoreRoutingData
* @return HelixZkClient
*/
// TODO: remove MetadataStoreRoutingData
RealmAwareZkClient buildZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
RealmAwareZkClient.RealmAwareZkClientConfig clientConfig);
RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
MetadataStoreRoutingData metadataStoreRoutingData);

/**
* Builds a RealmAwareZkClient using specified connection config and default client config.
* @param connectionConfig
* @param metadataStoreRoutingData
* @return RealmAwareZkClient
*/
RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig);
// TODO: remove MetadataStoreRoutingData
default RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
MetadataStoreRoutingData metadataStoreRoutingData) {
return buildZkClient(connectionConfig, new RealmAwareZkClient.RealmAwareZkClientConfig(),
metadataStoreRoutingData);
}
}
Loading