Improve CustomizedStateProvider tests#840
Merged
jiajunwang merged 1 commit intoapache:customizeViewfrom Mar 3, 2020
Merged
Conversation
zhangmeng916
approved these changes
Mar 3, 2020
Contributor
zhangmeng916
left a comment
There was a problem hiding this comment.
Great work in adding these test cases!
zhangmeng916
approved these changes
Mar 3, 2020
Contributor
Author
|
This PR is ready to be merged, approved by @zhangmeng916 . |
mgao0
added a commit
to mgao0/helix
that referenced
this pull request
Mar 7, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 2, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 4, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 13, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 14, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 23, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
jiajunwang
pushed a commit
that referenced
this pull request
Apr 23, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#728
Description
This PR added tests to make CustomizedStateProvider tests comprehensive.
Tests
TestCustomizedStateUpdate
START TestCustomizedStateUpdate at Mon Mar 02 17:34:44 PST 2020
START testDeleteNonExistingPerPartitionCustomizedState at Mon Mar 02 17:34:46 PST 2020
Default Suite
Total tests run: 6, Failures: 0, Skips: 0
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)