Skip to content

Improve CustomizedStateProvider tests#840

Merged
jiajunwang merged 1 commit intoapache:customizeViewfrom
mgao0:customizeView
Mar 3, 2020
Merged

Improve CustomizedStateProvider tests#840
jiajunwang merged 1 commit intoapache:customizeViewfrom
mgao0:customizeView

Conversation

@mgao0
Copy link
Contributor

@mgao0 mgao0 commented Mar 2, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#728

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR added tests to make CustomizedStateProvider tests comprehensive.

Tests

  • The following tests are written for this issue:

TestCustomizedStateUpdate

  • The following is the result of the "mvn test" command on the appropriate module:

START TestCustomizedStateUpdate at Mon Mar 02 17:34:44 PST 2020
START testDeleteNonExistingPerPartitionCustomizedState at Mon Mar 02 17:34:46 PST 2020

Default Suite
Total tests run: 6, Failures: 0, Skips: 0

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@mgao0 mgao0 changed the title WIP Improved CustomizedStateProvider tests WIP Improve CustomizedStateProvider tests Mar 2, 2020
Copy link
Contributor

@zhangmeng916 zhangmeng916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work in adding these test cases!

@mgao0 mgao0 changed the title WIP Improve CustomizedStateProvider tests Improve CustomizedStateProvider tests Mar 3, 2020
@mgao0
Copy link
Contributor Author

mgao0 commented Mar 3, 2020

This PR is ready to be merged, approved by @zhangmeng916 .

@jiajunwang jiajunwang merged commit d23b54a into apache:customizeView Mar 3, 2020
mgao0 added a commit to mgao0/helix that referenced this pull request Mar 7, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 2, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 4, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 13, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 14, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 23, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
jiajunwang pushed a commit that referenced this pull request Apr 23, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
Add tests to make CustomizedStateProvider tests comprehensive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants