Implement setRoutingData for MetadataStoreDirectoryService#844
Merged
narendly merged 5 commits intoapache:zooscalabilityfrom Mar 4, 2020
Merged
Conversation
huizhilu
reviewed
Mar 2, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...ava/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataWriter.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataWriter.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...-rest/src/test/java/org/apache/helix/rest/server/MetadataStoreDirectoryAccessorTestBase.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/test/java/org/apache/helix/rest/server/TestMetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...ore-directory-common/src/main/java/org/apache/helix/msdcommon/datamodel/TrieRoutingData.java
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/TestZkMetadataStoreDirectory.java
Show resolved
Hide resolved
narendly
reviewed
Mar 3, 2020
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
Show resolved
Hide resolved
Contributor
Author
|
This PR is ready to be merged, approved by @narendly Implement setRoutingData for MetadataStoreDirectoryServiceImplement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory. |
narendly
pushed a commit
to narendly/helix
that referenced
this pull request
Mar 17, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
narendly
pushed a commit
to narendly/helix
that referenced
this pull request
Apr 1, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
narendly
pushed a commit
to narendly/helix
that referenced
this pull request
Apr 1, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
asfgit
pushed a commit
that referenced
this pull request
Apr 1, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
asfgit
pushed a commit
that referenced
this pull request
Apr 8, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
narendly
pushed a commit
that referenced
this pull request
Apr 9, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
Implement setRoutingData endpoint. Modify TrieRoutingData construction in MetadataStoreDirectory. Fix race conditions among writing operations in MetadataStoreDirectory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #841, #842, #843
Description
This PR implements
setRoutingData, which was an endpoint that was defined but not finished. It allows users to overwrite whatever routing data there is for a namespace and replace it with a new set of data. This endpoint was designed with convenience in mind because it allows users to specify the routing data in one call instead of making multiple calls to create zkrealms and add sharding keys. This endpoint was originally designed to validate the input but now it doesn't, please refer #842 for the reasoning.Related to this PR, we also discovered that there are problems related to the construction of
TrieRoutingDatainMetadataStoreDirectory. Please see #841 .Lastly, we are also fixing the race conditions of writing operations in
MetadataStoreDirectorywhich are discovered during the development. Please see #843.Tests
[INFO] Tests run: 140, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.602 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 140, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53.115 s
[INFO] Finished at: 2020-03-02T14:38:49-08:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality