Async write operation should not throw Exception for serializing error#845
Merged
jiajunwang merged 2 commits intoapache:masterfrom Mar 3, 2020
Merged
Async write operation should not throw Exception for serializing error#845jiajunwang merged 2 commits intoapache:masterfrom
jiajunwang merged 2 commits intoapache:masterfrom
Conversation
This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure. In addition, according to serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
huizhilu
approved these changes
Mar 3, 2020
helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/manager/zk/TestRawZkClient.java
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/manager/zk/TestRawZkClient.java
Show resolved
Hide resolved
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
Show resolved
Hide resolved
huizhilu
reviewed
Mar 3, 2020
helix-core/src/test/java/org/apache/helix/manager/zk/TestRawZkClient.java
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/manager/zk/TestRawZkClient.java
Show resolved
Hide resolved
Contributor
Author
|
This PR is ready to be merged, approved by @pkuwm |
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 4, 2020
apache#845) This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure. In addition, according to the serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
7 tasks
jiajunwang
pushed a commit
to jiajunwang/helix
that referenced
this pull request
May 6, 2020
apache#845) This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure. In addition, according to the serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
jiajunwang
added a commit
that referenced
this pull request
May 6, 2020
#845) (#999) This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure. In addition, according to the serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
jiajunwang
pushed a commit
that referenced
this pull request
May 7, 2020
#845) (#999) This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure. In addition, according to the serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
apache#845) This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure. In addition, according to the serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#805
Description
This change will make the async write operations return error through the async callback instead of throwing exceptions. This change will fix the batch write/create failure due to one single node serializing failure.
In addition, according to serializer interface definition, change ZK related serializers to throw ZkMarshallingError instead of ZkClientException.
Tests
testAsyncWriteOperations
Failed tests:
TestJobQueueCleanUp.testJobQueueAutoCleanUp » ThreadTimeout Method org.testng....
TestWorkflowTermination.testWorkflowJobFail:251->verifyWorkflowCleanup:257 expected: but was:
Tests run: 1086, Failures: 2, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
retrun:
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57.613 s
[INFO] Finished at: 2020-03-02T16:43:29-08:00
[INFO] ------------------------------------------------------------------------
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)