Make ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware#863
Merged
narendly merged 5 commits intoapache:zooscalabilityfrom Mar 12, 2020
Merged
Make ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware#863narendly merged 5 commits intoapache:zooscalabilityfrom
narendly merged 5 commits intoapache:zooscalabilityfrom
Conversation
7 tasks
huizhilu
reviewed
Mar 6, 2020
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
Show resolved
Hide resolved
huizhilu
reviewed
Mar 6, 2020
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
Show resolved
Hide resolved
lei-xia
reviewed
Mar 9, 2020
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
Show resolved
Hide resolved
lei-xia
reviewed
Mar 9, 2020
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
Show resolved
Hide resolved
huizhilu
reviewed
Mar 11, 2020
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
Show resolved
Hide resolved
junkaixue
approved these changes
Mar 11, 2020
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
LGTM. But please address remaining concerns.
6a1ef02 to
88c5ee2
Compare
Contributor
Author
|
This PR is ready to be merged, approved by @dasahcc This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. |
narendly
added a commit
to narendly/helix
that referenced
this pull request
Mar 17, 2020
…ache#863) This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
narendly
added a commit
to narendly/helix
that referenced
this pull request
Apr 1, 2020
…ache#863) This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
narendly
added a commit
to narendly/helix
that referenced
this pull request
Apr 1, 2020
…ache#863) This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
asfgit
pushed a commit
that referenced
this pull request
Apr 1, 2020
This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
asfgit
pushed a commit
that referenced
this pull request
Apr 8, 2020
This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
narendly
added a commit
that referenced
this pull request
Apr 9, 2020
This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
…ache#863) This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config. Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #862
Description
This commit makes both ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware by choosing the appropriate realm-aware ZkClients in the constructor. Also, we add a Builder here to give users options to set Connection config and Client config.
Note that ZkHelixPropertyStore extends CacheBaseDataAccessor so there is no change needed.
Tests
The following tests cover ZkCacheBaseDataAccessor:
TestZkCacheAsyncOpSingleThread,TestZkCacheSyncOpSingleThread,TestWtCacheSyncOpSingleThread,TestWtCacheAsyncOpMultiThread
mvn test -Dtest=TestZkCacheAsyncOpSingleThread,TestZkCacheSyncOpSingleThread,TestWtCacheSyncOpSingleThread,TestWtCacheAsyncOpMultiThreadhelix-core:
mvn test -Dtest=TestEnableCompression,TestControllerLeadershipChangeCommits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)