Make ZkHelixClusterVerifier and its child classes realm-aware#867
Merged
narendly merged 5 commits intoapache:zooscalabilityfrom Mar 12, 2020
Merged
Make ZkHelixClusterVerifier and its child classes realm-aware#867narendly merged 5 commits intoapache:zooscalabilityfrom
narendly merged 5 commits intoapache:zooscalabilityfrom
Conversation
jiajunwang
reviewed
Mar 6, 2020
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Show resolved
Hide resolved
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/ClusterLiveNodesVerifier.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/ZkHelixClusterVerifier.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Mar 9, 2020
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
Show resolved
Hide resolved
huizhilu
reviewed
Mar 11, 2020
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Show resolved
Hide resolved
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Show resolved
Hide resolved
junkaixue
approved these changes
Mar 11, 2020
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Remember to add TODO for Builder refactoring.
Changelist: 1. Make sure constructors accept RealmAwareZkClient 2. Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
93b474c to
922b706
Compare
Contributor
Author
|
This PR is ready to be merged, approved by @dasahcc Changelist: |
narendly
added a commit
to narendly/helix
that referenced
this pull request
Mar 17, 2020
…#867) Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
narendly
added a commit
to narendly/helix
that referenced
this pull request
Apr 1, 2020
…#867) Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
narendly
added a commit
to narendly/helix
that referenced
this pull request
Apr 1, 2020
…#867) Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
asfgit
pushed a commit
that referenced
this pull request
Apr 1, 2020
Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
asfgit
pushed a commit
that referenced
this pull request
Apr 8, 2020
Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
narendly
added a commit
that referenced
this pull request
Apr 9, 2020
Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
…#867) Changelist: Make sure constructors accept RealmAwareZkClient Add Builders in each child class of ZkHelixClusterVerifier so that ZkClient configs are configurable and uses realm-aware ZkClient APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #866
Description
Changelist:
Tests
Covered by existing tests
helix-core:
mvn test -Dtest=TestCleanupExternalView,TestEnableCompression,TestRebalanceRunningTask,TestHelixAdminCliCommits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)