Skip to content

Downgrade the log level to INFO when isInstanceSetup() fails#870

Merged
jiajunwang merged 1 commit intoapache:masterfrom
jiajunwang:log
Mar 6, 2020
Merged

Downgrade the log level to INFO when isInstanceSetup() fails#870
jiajunwang merged 1 commit intoapache:masterfrom
jiajunwang:log

Conversation

@jiajunwang
Copy link
Contributor

@jiajunwang jiajunwang commented Mar 6, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#692

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Follow the log convention in ZKUtil class and downgrade the log level to INFO when isInstanceSetup() fails. This change avoids verbose error log that misleads the users.

Tests

  • The following tests are written for this issue:

NA

  • The following is the result of the "mvn test" command on the appropriate module:

NA, log change only.

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@huizhilu huizhilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiajunwang
Copy link
Contributor Author

This PR is ready to be merged, approved by @pkuwm

@jiajunwang jiajunwang merged commit 3e264f0 into apache:master Mar 6, 2020
@jiajunwang jiajunwang deleted the log branch March 6, 2020 05:38
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 4, 2020
…#870)

Follow the log convention in ZKUtil class and downgrade the log level to INFO when isInstanceSetup() fails. This change avoids verbose error log that misleads the users.
asfgit pushed a commit that referenced this pull request May 6, 2020
Follow the log convention in ZKUtil class and downgrade the log level to INFO when isInstanceSetup() fails. This change avoids verbose error log that misleads the users.
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
…#870)

Follow the log convention in ZKUtil class and downgrade the log level to INFO when isInstanceSetup() fails. This change avoids verbose error log that misleads the users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants