Skip to content

Change the cluster creation logic#872

Merged
junkaixue merged 2 commits intoapache:helix-cloudfrom
alirezazamani:helix-cloud-newPR
Mar 6, 2020
Merged

Change the cluster creation logic#872
junkaixue merged 2 commits intoapache:helix-cloudfrom
alirezazamani:helix-cloud-newPR

Conversation

@alirezazamani
Copy link

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    In this PR, a minor modification has been added which:
    1- Populated the Topology information in the Cluster Config
    if cloud is enabled.
    2- Tests have been change accordingly.
    3- The deprecated APIs have been changed in the test to
    follow new APIs.

Tests

  • The following is the result of the "mvn test" command on the appropriate module:

Helix-core:
[INFO] Tests run: 906, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,585.59 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 906, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59:51 min
[INFO] Finished at: 2020-03-05T20:13:30-08:00
[INFO] ------------------------------------------------------------------------

Helix-Rest:
[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.966 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.294 s
[INFO] Finished at: 2020-03-05T19:12:48-08:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml

In this commit, a minor modification has been added which:
1- Populated the Topology information in the Cluster Config
if cloud is enabled.
2- Tests have been change accordingly.
3- The depricated APIs have been changed in the test to
follow new APIs.
Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alirezazamani
Copy link
Author

This PR is ready to be merged, approved by @dasahcc and @jiajunwang

FInal Commit message:

Title:
Add cluster config update for cluster creation logic in Azure

Body:
In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.

@junkaixue junkaixue merged commit ba7ced1 into apache:helix-cloud Mar 6, 2020
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Apr 6, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
junkaixue pushed a commit that referenced this pull request Apr 7, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
junkaixue pushed a commit that referenced this pull request Apr 14, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
@alirezazamani alirezazamani deleted the helix-cloud-newPR branch June 8, 2020 21:11
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Aug 25, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Nov 12, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
zhangmeng916 pushed a commit to zhangmeng916/helix that referenced this pull request Nov 18, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
jiajunwang pushed a commit that referenced this pull request Nov 18, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
jiajunwang pushed a commit that referenced this pull request Nov 19, 2020
* Change the cluster creation logic

In this commit, minor modifications have been added which:
1- Update topology information in the Cluster Config
if cloud is enabled for Azure environment.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants