Change the cluster creation logic#872
Merged
junkaixue merged 2 commits intoapache:helix-cloudfrom Mar 6, 2020
Merged
Conversation
In this commit, a minor modification has been added which: 1- Populated the Topology information in the Cluster Config if cloud is enabled. 2- Tests have been change accordingly. 3- The depricated APIs have been changed in the test to follow new APIs.
jiajunwang
reviewed
Mar 6, 2020
junkaixue
reviewed
Mar 6, 2020
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
jiajunwang
approved these changes
Mar 6, 2020
Author
|
This PR is ready to be merged, approved by @dasahcc and @jiajunwang FInal Commit message: Title: Body: |
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 6, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
junkaixue
pushed a commit
that referenced
this pull request
Apr 7, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
junkaixue
pushed a commit
that referenced
this pull request
Apr 14, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Aug 25, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Nov 12, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Nov 18, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
jiajunwang
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
jiajunwang
pushed a commit
that referenced
this pull request
Nov 19, 2020
* Change the cluster creation logic In this commit, minor modifications have been added which: 1- Update topology information in the Cluster Config if cloud is enabled for Azure environment. 2- Tests have been change accordingly. 3- The deprecated APIs have been changed in the test to follow new APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes TODO: Populate topology information while creating cluster #871
Description
In this PR, a minor modification has been added which:
1- Populated the Topology information in the Cluster Config
if cloud is enabled.
2- Tests have been change accordingly.
3- The deprecated APIs have been changed in the test to
follow new APIs.
Tests
Helix-core:
[INFO] Tests run: 906, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,585.59 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 906, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59:51 min
[INFO] Finished at: 2020-03-05T20:13:30-08:00
[INFO] ------------------------------------------------------------------------
Helix-Rest:
[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.966 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.294 s
[INFO] Finished at: 2020-03-05T19:12:48-08:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality