Add construction of domain in Helix participant logic#876
Add construction of domain in Helix participant logic#876junkaixue merged 3 commits intoapache:helix-cloudfrom
Conversation
85314f8 to
c59bc5e
Compare
| } | ||
|
|
||
| private String ConstructDomainField(String faultDomain) { | ||
| Boolean topologyEnabled = _configAccessor.getClusterConfig(_clusterName).isTopologyAwareEnabled(); |
There was a problem hiding this comment.
Do we need this? If we know the environment is Azure, then we can directly get the topology from AzureConstants instead of reading from ClusterConfig.
There was a problem hiding this comment.
In this logic, we do not parse the cloud provider directly. That logic is in the processor. I was thinking that if we read from clusterConfig, it'll be generic, and independent of cloud provider. thoughts?
There was a problem hiding this comment.
Discussed offline. We'll move the logic to cloud instance information processor and not to depend on cluster config.
c59bc5e to
bebadf1
Compare
...-core/src/main/java/org/apache/helix/cloud/azure/AzureCloudInstanceInformationProcessor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
Show resolved
Hide resolved
|
This PR is ready to merge, approved by @dasahcc |
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Add the construction of domain field in Azure cloud instance information processor. It will read the topology from AzureConstants, and construct the domain based on the format of the topology.
Issues
(#875 )
Description
Helix has a topology defined in cluster config, e.g., "TOPOLOGY": "/zone/host", and it will be used to construct the "domain" field in participant config, e.g. ""DOMAIN": "zone=0,host=host1". In Azure, Helix will provide a default topology value for the cluster, and the format is /faultDomain/hostName. In this pR, we add the construction function in Participant manager to construct the domain field based on this topology.
Tests
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)