Change the REST call for delete CloudConfig #882
Merged
junkaixue merged 2 commits intoapache:helix-cloudfrom Mar 13, 2020
Merged
Change the REST call for delete CloudConfig #882junkaixue merged 2 commits intoapache:helix-cloudfrom
junkaixue merged 2 commits intoapache:helix-cloudfrom
Conversation
junkaixue
reviewed
Mar 10, 2020
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
Show resolved
Hide resolved
junkaixue
reviewed
Mar 10, 2020
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
Outdated
Show resolved
Hide resolved
Contributor
|
Wait... Sorry for the confusing here. You have delete REST config in HelixAdmin. Then you dont need to move the whole logic to config accessor. In the ClusterAccesor, when you delete the REST config, what you need to do is call HelixAdmin's delete REST config. |
Contributor
|
But we need update/delete operation for per entry in REST config. |
Use DELETE instead of POST for deletion of the CloudConfig in REST.
953ff70 to
40aca9d
Compare
junkaixue
approved these changes
Mar 13, 2020
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Overall, LGTM. Please remove the line I commented.
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
Outdated
Show resolved
Hide resolved
Author
|
This PR is ready to be merged, approved by @dasahcc. Final commit message: Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST. |
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Apr 6, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
junkaixue
pushed a commit
that referenced
this pull request
Apr 7, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
junkaixue
pushed a commit
that referenced
this pull request
Apr 14, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Aug 25, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Nov 12, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
zhangmeng916
pushed a commit
to zhangmeng916/helix
that referenced
this pull request
Nov 18, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
jiajunwang
pushed a commit
that referenced
this pull request
Nov 18, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
jiajunwang
pushed a commit
that referenced
this pull request
Nov 19, 2020
Change the delete CloudConfig Use DELETE instead of POST for deletion of the CloudConfig in REST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes TODO: change the REST API for cloud config deletion #881
Description
In this PR, the necessary changes has been made to the REST API call for cloud config deletion.
Previously we were using POST (command.delete) to delete the cloud config. With this new change, we can use DELETE request to delete the cloud config.
The tests has been changed accordingly.
Tests
helix-core:
[INFO] Results:
[INFO]
[INFO] Tests run: 906, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57:50 min
[INFO] Finished at: 2020-03-09T21:16:59-07:00
[INFO] ------------------------------------------------------------------------
helix-rest:
[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.976 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32.417 s
[INFO] Finished at: 2020-03-09T21:32:04-07:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality