fix: check single-alert labels in notification policy matching#3943
Closed
love12yadav wants to merge 3 commits intoapache:masterfrom
Closed
fix: check single-alert labels in notification policy matching#3943love12yadav wants to merge 3 commits intoapache:masterfrom
love12yadav wants to merge 3 commits intoapache:masterfrom
Conversation
… and multiple credentials (#3925) Signed-off-by: Love yadav <155807335+love12yadav@users.noreply.github.com>
…rg/apache/hertzbeat/collector/collect/common/ssh/SshHelper.java Signed-off-by: Love yadav <155807335+love12yadav@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Notification policies with custom labels (e.g., department:algorithm) never triggered. Only the "forward‑all" policy worked.
Reason: The matching logic only checked GroupAlert.commonLabels, while the label lived in SingleAlert.labels.
Solution
Updated NoticeConfigServiceImpl.getReceiverFilterRule() to also check each SingleAlert’s labels inside the group. Now label‑based policies fire correctly.