[refactor] Add monitorName parameter to history data query for consistent app handling

[Saramanda9988]

What's changed?

please refer to #3983

In the method of querying historical data, add the monitorName parameter. When the app is prometheus, automatically concatenate the prefix prometheus{monitorName} to ensure that the query and storage use the same app value

• HistoryDataReader - add the monitorName parameter to the interface method (marked @ Deprecated)
• MetricsDataController - API path changed from/api/monitor/{instance}/metric/{metricFull} to/ -api/monitor/{instance}/metric/{monitorName}/{metricFull}
• MetricsDataService - add the monitorName parameter to the service method

IotDb

Influxdb

QuestDb

TDengine

Checklist

• I have read the Contributing Guide
• I have written the necessary doc or comment.
• I have added the necessary unit tests and all cases have passed.

Add or update API

• I have added the necessary e2e tests and all cases have passed.

[Duansg]

Can we just directly convert the app here? That way, we won't need to adjust the REST API.

[Saramanda9988]

hi,thanks for your cr.
Do you mean we should modify the app parameter directly in the fe? Maybe that would require adjusting greptimedb and vm to align with other tsdbs.
Just concerned this adds complexity to these two storages that we'll support long-term. What do you think?

[Duansg]

Thanks for your reply.

1. VictoriaMetricsClusterDataStorage And VictoriaMetricsDataStorage

// saveData() method
if (metricsData.getApp().startsWith(CommonConstants.PROMETHEUS_APP_PREFIX)) {
    isPrometheusAuto = true;
}

// getHistoryMetricData()
String labelName = metrics + SPILT + metric;
if (CommonConstants.PROMETHEUS.equals(app)) { // app.startsWith(CommonConstants.PROMETHEUS_APP_PREFIX)
    labelName = metrics;
}
String timeSeriesSelector = Stream.of(
    LABEL_KEY_NAME + "=\"" + labelName + "\"",
    LABEL_KEY_INSTANCE + "=\"" + instance + "\"",
    CommonConstants.PROMETHEUS.equals(app) ? null : MONITOR_METRIC_KEY + "=\"" + metric + "\"" // app.startsWith(CommonConstants.PROMETHEUS_APP_PREFIX)
).filter(Objects::nonNull).collect(Collectors.joining(","));

2. GreptimeDbDataStorage: getHistoryMetricData() and getHistoryIntervalMetricData()

if (!CommonConstants.PROMETHEUS.equals(app)) { // default :  String timeSeriesSelector = LABEL_KEY_NAME + "=\"" + name + "\"" + "," + LABEL_KEY_INSTANCE + "=\"" + instance + "\"";
    timeSeriesSelector = timeSeriesSelector + "," + LABEL_KEY_FIELD + "=\"" + metric + "\"";
}

Theoretically, only the VM needs to be modified, right? And since the VM is saved through its mapping, maintaining consistency shouldn't be an issue. What do you think?

[Saramanda9988]

@Duansg , hi thanks for your reply

Yes, you're right. Let's do it this way.
I'll close this PR and submit a new one following your suggestion; it will be much simpler.

[Duansg]

Should monitorName be exposed to the Tool? I believe this is an unstable parameter and doesn't need to be exposed externally. It should remain within the internal normalization layer. I recommend performing app conversion internally.