feat(monitor): add Prometheus Remote Write receiver monitoring template#4104
feat(monitor): add Prometheus Remote Write receiver monitoring template#4104abhyudayareddy wants to merge 1 commit into
Conversation
This template monitors the health, throughput, and error rate of a Prometheus Remote Write receiver endpoint. It includes parameters for host, port, metrics path, and SSL configuration. Signed-off-by: abhyudayareddy <54602866+abhyudayareddy@users.noreply.github.com>
|
This issue appears to involve implementing a protocol adapter that supports Prometheus remote write and remote read via hertzbeat. pls confirm its relevance to this PR. |
|
Hi @Duansg, thanks for reviewing! To clarify the distinction: issue #1945 is about HertzBeat itself acting as a Prometheus remote write storage backend — i.e., other systems pushing metrics into HertzBeat via the remote write protocol. That is a different feature entirely. This PR adds a monitoring template so that HertzBeat can monitor external services that expose a Prometheus Remote Write receiver endpoint (e.g., Thanos Receive, Cortex, Mimir, VictoriaMetrics). HertzBeat scrapes their In short:
|
|
@abhyudayareddy Hi, overall, this PR has the following issues:
Given this, I cannot approve this PR. @zqr10159 could you please review it? |
|
Sorry, these are clearly two different things, and I cannot pass this PR. |
|
Thank you both @Duansg and @zqr10159 for taking the time to review! I want to address point 3 specifically, as I think there may be a misunderstanding: Prometheus Remote Write receiver monitoring is fundamentally different from scraping a
On point 2: I'd genuinely appreciate if you could point out the specific errors in the template so I can fix them. I want to make sure the YAML is correct. On point 1: I understand this is separate from issue #1945 (HertzBeat ingesting remote write data itself). This PR's scope is narrower — monitoring external remote write receivers. I can update the PR title/description to make that distinction clearer if that would help reconsider. |
|
@Duansg @zqr10159 — following up on my previous comment (no response since Apr 14). I want to make sure the distinction is clear: this PR monitors external Prometheus Remote Write receiver services (Thanos Receive, Cortex, Mimir, VictoriaMetrics) by checking their health/readiness endpoints ( On the YAML errors:
|
Summary
Adds a new HertzBeat monitoring template for Prometheus Remote Write receiver endpoints (e.g. Thanos Receive, Cortex, Mimir, VictoriaMetrics).
Closes/relates to #1945 — "Historical data storage supports Prometheus remote write and remote read protocols"
What's changed?
app-prometheus-remote-write.ymlunderhertzbeat-manager/src/main/resources/define/parseType: prometheus(HTTP collection) consistent with HertzBeat's existing Prometheus integrationavailability— scrape up/down checkthroughput— samples appended, remote write requests received/failedlatency— histogram quantile P50/P95/P99 for remote write durationwal_health— WAL corruptions and truncation failures/metrics), SSL, basic authChecklist