HIVE-22674: Replace Base64 in serde Package#1203
Merged
belugabehr merged 4 commits intoapache:masterfrom Jul 22, 2020
Merged
Conversation
kgyrtkirk
added
tests pending
tests unstable
tests failed
and removed
tests pending
tests unstable
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
Contributor
Author
|
@kgyrtkirk This one has been plaguing me for a long time. I thought CI was failing because of flakiness, but no, it was an actual problem. I finally sat down to figure it out. I understand the comment in the code now about making this Base64 stuff configurable. I opened HIVE-23829 explaining why we need this and tracking the work. Thanks. Hopefully tests will pass with update qtest in place. |
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
Contributor
Author
|
@kgyrtkirk You looked at this once before. Are you able to provide a review? |
nrg4878
approved these changes
Jul 21, 2020
Contributor
nrg4878
left a comment
nrg4878
left a comment
There was a problem hiding this comment.
Change looks good to me. +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.