HIVE-23807 Wrong results with vectorization enabled #1212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han 1 child (Pengcheng Xiong, reviewed by Ashutosh Chauhan)
…nts on some operators (Jason Dere, reviewed by Gopal V)
…garwal via Thejas Nair)
…ukhin, reviewed by Gopal Vijayaraghavan)
…tResultSetMetaData (Pengcheng Xiong, reviewed by Ashutosh Chauhan)
…pplication (Wei Zheng, reviewed by Eugene Koifman)
…onfig should load defaults (Sergey Shelukhin, reviewed by Siddharth Seth)
…pplication, ADDENDUM
…autogather column stats is on (Pengcheng Xiong, reviewed by Ashutosh Chauhan)
…epping, reviewed by Sergio Pena, Ashutosh Chauhan)
…ion back to hive warehouse (Vihang Karajgaonkar, reviewed by Sergio Pena, Ying Chen)
…ion back to hive warehouse (Vihang Karajgaonkar, reviewed by Sergio Pena, Ying Chen) (addendum I)
…Shelukhin, reviewed by Siddharth Seth)
…rgey Shelukhin, reviewed by Siddharth Seth)
… Infinity value in double column (Pengcheng Xiong, reviewed by Ashutosh Chauhan)
…ition/list bucket tables & inserting cross blobstore tables (Rentao Wu, reviewed by Sergio Pena)
…e been processed (Chao Sun, reviewed by Xuefu Zhang)
…ao Li reviewed by Vaibhav Gumashta)
…oifman, reviewed by Wei Zheng)
…, reviewed by Sergey Shelukhin)
…iong, reviewed by Ashutosh Chauhan)
…ia Pengcheng Xiong)
… transactional and non-transactional listeners. (Sergio Pena, reviewed by Mohit Sabharwal, Alexander Kolbasov)
…khin, reviewed by Prasanth Jayachandran)
…ukhin, reviewed by Prasanth Jayachandran)
… in use (Daniel Dai, reviewed by Laszlo Pinter, Thejas Nair) Signed-off-by: Thejas M Nair <thejas@hortonworks.com>
… in use (Daniel Dai, reviewed by Laszlo Pinter, Thejas Nair) Signed-off-by: Thejas M Nair <thejas@hortonworks.com>
… Dai, reviewed by Thejas Nair)
(Prasanth Jayachandran reviewed by Sergey Shelukhin) Added additional test case from HIVE-19638. Signed-off-by: Owen O'Malley <omalley@apache.org>
Fixes apache#590 Signed-off-by: Owen O'Malley <omalley@apache.org>
…Piotr Findeisen via Alan Gates)
…on JDK10 or newer (Ana Jalba, via Peter Vary)
jcamachor
reviewed
Jul 7, 2020
| String dateString = new String(inV.vector[i], inV.start[i], inV.length[i], StandardCharsets.UTF_8); | ||
| if (dateParser.parseDate(dateString, sqlDate)) { | ||
| try { | ||
| Date utilDate = Date.valueOf(dateString); |
Contributor
There was a problem hiding this comment.
Is this vectorized expression generated for GenericUDFDate? It seems that UDF still relies on DateParser in this branch:
Since the change may have an effect on parsing of other dates, it may be good to have a test run. It seems we have a jenkins active for branch-2 patches: http://130.211.9.232/job/hive-precommit/job/branch-2/ . I am wondering whether a PR against branch-2 will trigger it or whether we can trigger it manually. Could you verify?
Contributor
Author
There was a problem hiding this comment.
Yes this vectorized expression is generated for GenericUDFDate. I don't see any way to trigger precommit job manually for branch-2. @kgyrtkirk Do you know how can I trigger ptest for branch-2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute