HIVE-23818: Use String Switch-Case Statement in StatUtills#1229
Merged
belugabehr merged 2 commits intoapache:masterfrom Jul 17, 2020
Merged
HIVE-23818: Use String Switch-Case Statement in StatUtills#1229belugabehr merged 2 commits intoapache:masterfrom
belugabehr merged 2 commits intoapache:masterfrom
Conversation
miklosgergely
approved these changes
Jul 8, 2020
kgyrtkirk
reviewed
Jul 9, 2020
| } else if (colTypeLowerCase.equals(serdeConstants.BIGINT_TYPE_NAME) | ||
| || colTypeLowerCase.equals("long")) { | ||
| case serdeConstants.BIGINT_TYPE_NAME: | ||
| case "long": |
Member
There was a problem hiding this comment.
interesting...do we accept long as a typename?
I see that we have KW_LONG defined ; but not used at all...we may have it as an alias for BIGINT....
anyway...I don't think this line is doing anything here...
Contributor
Author
There was a problem hiding this comment.
Since this JIRA is about using the switch / clean up, I don't really want to change any behaviors. Can you please open a JIRA to explore this?
Member
|
tests show that this change causes a slight change in datasize estimation |
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Contributor
Author
|
@kgyrtkirk Thanks a million for pointing that out. I addressed the issue, tests pass, and I have merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.