HIVE-23832: Compaction cleaner fails to clean up deltas when using bl…#1243
Merged
deniskuzZ merged 1 commit intoapache:masterfrom Jul 14, 2020
Merged
HIVE-23832: Compaction cleaner fails to clean up deltas when using bl…#1243deniskuzZ merged 1 commit intoapache:masterfrom
deniskuzZ merged 1 commit intoapache:masterfrom
Conversation
lcspinter
reviewed
Jul 13, 2020
| //double wait time until 5min | ||
| waitTimeMs = waitTimeMs*2; | ||
| waitTimeMs = Math.max(waitTimeMs, waitTimeOut); | ||
| waitTimeMs = Math.min(waitTimeMs, waitTimeOut); |
Contributor
There was a problem hiding this comment.
Why do we need this change? Per the documentation, the minimum wait timeout is 2000 ms
Member
Author
There was a problem hiding this comment.
hive.compactor.wait.timeout default is 300000ms (5 min) - that's max,
start wait time = (waitTimeMs = 1000) X 2 = 2000ms;
lcspinter
approved these changes
Jul 13, 2020
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
…ocking compaction
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
abstractdog
pushed a commit
to abstractdog/hive
that referenced
this pull request
Apr 9, 2021
…en using blocking compaction (Denys Kuzmenko, reviewed by Laszlo Pinter) Closes (apache#1243) Change-Id: I42036fb5cc504132e50e25b89e9aa31d92c37024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocking compaction
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute