HIVE-24586: Rename compaction 'attempted' status #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
pvargacl
reviewed
Jan 6, 2021
| ShowCompactResponse rsp = txnHandler.showCompact(new ShowCompactRequest()); | ||
| List<ShowCompactResponseElement> compacts = rsp.getCompacts(); | ||
| Assert.assertEquals(1, compacts.size()); | ||
| Assert.assertEquals("did not initiate", compacts.get(0).getState()); |
Contributor
There was a problem hiding this comment.
I just noticed that in Initiator.scheduleCompactionIfRequired the exception is not passed to CompactionInfo, so it won't get saved. Could you also fix that, and here you could check if it was saved correctly.
kgyrtkirk
added
tests pending
tests failed
tests passed
and removed
tests failed
tests pending
labels
Contributor
|
You should also modify the COMPACTIONS view in sys db (hive-schema-4.0.0.hive.sql) |
Contributor
|
LGTM +1 |
pvary
reviewed
Jan 7, 2021
| COMPACTOR_HISTORY_RETENTION_ATTEMPTED("hive.compactor.history.retention.attempted", 2, | ||
| new RangeValidator(0, 100), "Determines how many attempted compaction records will be " + | ||
| "retained in compaction history for a given table/partition."), | ||
| @Deprecated COMPACTOR_HISTORY_RETENTION_DID_NOT_INITIATE("hive.compactor.history.retention.attempted", 2, |
Contributor
There was a problem hiding this comment.
Could we use configuration deprecation to change the name of the config as well? Otherwise we will carry this baggage forever.
pvary
reviewed
Jan 7, 2021
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| import static org.apache.hadoop.hive.ql.txn.compactor.CompactorTestUtilities.CompactorThreadType; |
kgyrtkirk
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests failed
tests passed
and removed
tests failed
tests pending
labels
pvary
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename compaction 'attempted' status to 'did not initiate'
Why are the changes needed?
See HIVE-24587.
Does this PR introduce any user-facing change?
Show compactions and sys.COMPACTIONS tables will list "attempted" status as "did not initiate" now.
How was this patch tested?
Unit test for case of initiator failure.