Skip to content

HIVE-24672: compute_stats_long.q fails for wrong reasons#1896

Closed
mustafaiman wants to merge 1 commit intoapache:masterfrom
mustafaiman:HIVE-24672
Closed

HIVE-24672: compute_stats_long.q fails for wrong reasons#1896
mustafaiman wants to merge 1 commit intoapache:masterfrom
mustafaiman:HIVE-24672

Conversation

@mustafaiman
Copy link
Contributor

Change-Id: I61d941dcbf86fb2dd45772fc658b3dc887325bd0

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Change-Id: I61d941dcbf86fb2dd45772fc658b3dc887325bd0
Copy link
Contributor

@zeroflag zeroflag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

-- compute stats should raise an error since the number of bit vectors > 1024
select compute_stats(a, 10000) from tab_int;
-- this should raise an error since the number of bit vectors has a hard limit at 1024
select compute_stats(a, 'fm', 10000) from tab_int;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this limit apply only to fm algo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes see

public static NumDistinctValueEstimator getEmptyNumDistinctValueEstimator(String func,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abstractdog abstractdog self-requested a review January 21, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants