HIVE-24769: Included owner information in the Table object in Hi… #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veMetaStoreClient#getTables()
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
saihemanth-cloudera
changed the title
kgyrtkirk
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
nrg4878
approved these changes
Apr 8, 2021
Contributor
nrg4878
left a comment
nrg4878
left a comment
There was a problem hiding this comment.
Changes look good to me. +1 for me.
| req.setCapabilities(version); | ||
| req.setTblNames(tables); | ||
| req.setTablesPattern(tablePattern); | ||
| if (processorCapabilities != null) |
Contributor
There was a problem hiding this comment.
Thanks for adding the processorIdentifiier.
| List<String> parameterVals = new ArrayList<>(); | ||
| appendSimpleCondition(filterBuilder, "database.name", new String[] {db}, parameterVals); | ||
| appendSimpleCondition(filterBuilder, "database.catalogName", new String[] {catName}, parameterVals); | ||
| if(tbl_names != null){ |
Contributor
There was a problem hiding this comment.
We should add a comment to explain the strategy on how this API uses the input arguments.
Contributor
|
This is been committed to master. Please close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…veMetaStoreClient#getTables()
What changes were proposed in this pull request?
Table object has table owner information so that authorization can be done on these objects.
Why are the changes needed?
Otherwise, the "show tables" command in beeline shows all the tables in db instead of the user-owned tables. By having this info, we can filter out tables that are not owned by the user.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local Machine, Remote cluster.