HIVE-24821: Restrict parallel edge creation for invertable RS operators #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
kasakrisz
approved these changes
Feb 26, 2021
| ExprNodeConstantDesc exprNodeConstantDesc = (ExprNodeConstantDesc) expr; | ||
| return exprNodeConstantDesc.getFoldedFromCol(); | ||
| } | ||
| throw new RuntimeException("unexpected mapping expression!"); |
Contributor
There was a problem hiding this comment.
nit: a more specific checked exception would suit better here or just return null a later in colMappingInverseKeys handle the specific exception or null only.
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
aihuaxu
pushed a commit
to aihuaxu/hive
that referenced
this pull request
Mar 17, 2021
…rs (apache#2015) (Zoltan Haindrich reviewed by Krisztian Kasa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously the swo could have created situations which were not correctly handled by the parallel edge fixer.
Why are the changes needed?
To prevent strange npe-s caused when other things happen in the RS like col rename.
Does this PR introduce any user-facing change?
no
the patch also contains: HIVE-24823 (#2014)