HIVE-24729: Implement strategy for llap cache hydration#2106
Merged
szlta merged 3 commits intoapache:masterfrom Mar 30, 2021
Merged
HIVE-24729: Implement strategy for llap cache hydration#2106szlta merged 3 commits intoapache:masterfrom
szlta merged 3 commits intoapache:masterfrom
Conversation
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
Change-Id: I2b9fb73bad690ee6474683668bce2f8232e65848
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
szlta
reviewed
Mar 29, 2021
Contributor
szlta
left a comment
szlta
left a comment
There was a problem hiding this comment.
Looks good - minor comments
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BasicLlapCacheReplication.java
Outdated
Show resolved
Hide resolved
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheReplication.java
Outdated
Show resolved
Hide resolved
Change-Id: Ia970433a021eeae6328cdc9335cec3fcb837006f
kgyrtkirk
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
Change-Id: I24facd069f5cc3f757b12ef78069fc4359bd3b63
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a subtask for the cache hydration feature, providing an extensible strategy for saving/loading and a basic implementation which saves the cache content on shutdown and load it back on startup.
Why are the changes needed?
LLAP cache hydration will enable save/load the cache contents.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests were added.