Skip to content

HIVE-24935: Remove outdated check for correlated exists subqueries with full aggregate#2118

Merged
kasakrisz merged 1 commit intoapache:masterfrom
kasakrisz:HIVE-24935-master-remove-subquerychecks
Mar 31, 2021
Merged

HIVE-24935: Remove outdated check for correlated exists subqueries with full aggregate#2118
kasakrisz merged 1 commit intoapache:masterfrom
kasakrisz:HIVE-24935-master-remove-subquerychecks

Conversation

@kasakrisz
Copy link
Contributor

What changes were proposed in this pull request?

  1. Remove outdated comment lines and if condition which was moved to QBSubQueryParseInfo and implementations of ExprFactory.createSubqueryExpr
  2. Renamed boolean variable noImplicityGby -> hasExplicitGby and negate its semantics.

Why are the changes needed?

Code cleanup. This is a follow-up of: #2039

Does this PR introduce any user-facing change?

No.

How was this patch tested?

mvn test -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=subquery_full_aggregate.q -pl itests/qtest -Pitests

@kasakrisz kasakrisz merged commit ec26a51 into apache:master Mar 31, 2021
@kasakrisz kasakrisz deleted the HIVE-24935-master-remove-subquerychecks branch May 4, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants