HIVE-25257: Incorrect row order validation for query-based MAJOR comp…#2400
Merged
kuczoram merged 1 commit intoapache:masterfrom Jun 18, 2021
Merged
HIVE-25257: Incorrect row order validation for query-based MAJOR comp…#2400kuczoram merged 1 commit intoapache:masterfrom
kuczoram merged 1 commit intoapache:masterfrom
Conversation
Contributor
kuczoram
commented
Jun 16, 2021
- Fix the row order validation for the query-based MAJOR compaction. The rows should be in increasing order by originalTransactionId, bucketProperty, rowId. But in the validation the bucketProperty is checked first, which can cause failure if there are delta directories with multiple statementIds, like after multiple merge statements.
- Added unit test for this use-case
- Fixed the error message printed out in the GenericUDFValidateAcidSortOrder by adding a toString() method to the WriteIdRowId inner class.
lcspinter
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.