HIVE-25320: Purge hive.optimize.sort.dynamic.partition#2466
Merged
belugabehr merged 1 commit intoapache:masterfrom Jul 27, 2021
Merged
HIVE-25320: Purge hive.optimize.sort.dynamic.partition#2466belugabehr merged 1 commit intoapache:masterfrom
belugabehr merged 1 commit intoapache:masterfrom
Conversation
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
Contributor
|
HiveConf.ConfVars.HIVEOPTSORTDYNAMICPARTITION was not removed, though the jira says that it should be removed too. Is there a reason not to do so? |
Contributor
Author
I thought it refers to remove references of HIVEOPTSORTDYNAMICPARTITION in tests as well. I'm cleaning it up now! |
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
Contributor
|
+1 pending tests |
miklosgergely
approved these changes
Jul 13, 2021
Contributor
|
Can you please change PR (and JIRA) title to:
Please? |
sneakyburro
changed the title
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove all usages of
hive.optimize.sort.dynamic.partitionin query testsWhy are the changes needed?
hive.optimize.sort.dynamic.partitionwas deprecated and defuncted in source code base. The usages in query tests should be cleaned up.Does this PR introduce any user-facing change?
no
How was this patch tested?
rerun unit test and query tests