HIVE-25373 : Modify buildColumnStatsDesc to send configured number of stats for updation#2520
Merged
maheshk114 merged 2 commits intoapache:masterfrom Aug 3, 2021
Merged
Conversation
… stats for updation
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
rbalamohan
reviewed
Jul 28, 2021
| request.setValidWriteIdList(validWriteIdList.toString()); | ||
| } | ||
| } | ||
| db.setPartitionColumnStatistics(request); |
Contributor
There was a problem hiding this comment.
Info level logging would be good to have here. Since it will be printed for every 10K updates, it should be fine and will be helpful for debugging as well. And if possible provide time taken for overall buildColumnStatsDesc.
rbalamohan
reviewed
Jul 28, 2021
Contributor
rbalamohan
left a comment
rbalamohan
left a comment
There was a problem hiding this comment.
minor comment. Otherwise LGTM.
… stats for updation
kgyrtkirk
added
tests pending
tests unstable
tests failed
tests passed
and removed
tests passed
tests pending
tests unstable
tests failed
labels
Contributor
|
LGTM. +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Group the stats objects into different batches to avoid large message size to HMS.
Why are the changes needed?
If the number of stats exceeds limit, the operation may fail.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test