HIVE-25605: JdbcStorageHandler Create table fails when hive.sql.schem…#2710
Closed
cravani wants to merge 1 commit intoapache:masterfrom
Closed
HIVE-25605: JdbcStorageHandler Create table fails when hive.sql.schem…#2710cravani wants to merge 1 commit intoapache:masterfrom
cravani wants to merge 1 commit intoapache:masterfrom
Conversation
…a is specified and is not the default one
asolimando
reviewed
Oct 9, 2021
| // We generate query as select * | ||
| query = "select * from " + tableName; | ||
| if (schemaName != null) { | ||
| query = "select * from "+schemaName+"."+tableName; |
Member
There was a problem hiding this comment.
Can you put whitespaces before/after "+"?
asolimando
requested changes
Oct 9, 2021
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
The change looks good but at least one positive and one negative tests should be added, could you please do that?
Contributor
Author
|
Closing this PR, since fix will be taken care as part of HIVE-25591 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…a is specified and is not the default one
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?