HIVE-25346: cleanTxnToWriteIdTable breaks SNAPSHOT isolation #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
changed the title
deniskuzZ
force-pushed
the
HIVE-25346
branch
3 times, most recently
from
0d432d5 to
3f1392b
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
pvary
reviewed
Oct 18, 2021
|
|
||
| } catch (Exception e) { | ||
| throw new MetaException(StringUtils.stringifyException(e)); | ||
| try { |
Contributor
There was a problem hiding this comment.
Could we use try-with-resorces here for the statement and the dbConnection?
Member
Author
There was a problem hiding this comment.
we could, however, it would introduce 1 more level of nesting, I would prefer to keep it like this.
Contributor
There was a problem hiding this comment.
Maybe wrong, but the finally is only there for closing the dbConn and the stmt. We can skip that with try-with-resources.
Member
Author
There was a problem hiding this comment.
however, that would introduce few more levels of nesting: +2
pvary
reviewed
Oct 18, 2021
...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Show resolved
Hide resolved
pvary
reviewed
Oct 18, 2021
...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Show resolved
Hide resolved
pvary
reviewed
Oct 18, 2021
...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Show resolved
Hide resolved
pvary
reviewed
Oct 18, 2021
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
Show resolved
Hide resolved
pvary
reviewed
Oct 18, 2021
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
Show resolved
Hide resolved
…ces, removed redundant dbConn in checkRetryable
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
pvary
approved these changes
Oct 20, 2021
HarshitGupta11
pushed a commit
to HarshitGupta11/hive
that referenced
this pull request
Dec 12, 2021
…uzmenko, reviewed by Peter Vary) Closes apache#2716
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…uzmenko, reviewed by Peter Vary) Closes apache#2716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?