HIVE-25686: UDFSpace result length calculation is incorrect after HADOOP-17901 and HADOOP-17905 #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OOP-17901 and HADOOP-17905
zabetak
added
the
discussion-in-jira
HarshitGupta11
pushed a commit
to HarshitGupta11/hive
that referenced
this pull request
Dec 12, 2021
…P-17905 (Mark Bathori, reviewed by Stamatis Zampetakis) At the moment the problem does not appear cause Hive is still using 3.1.0 version. However, if Hadoop 3.4.0 (or greater) is in use the function generate incorrect results cause the underlying implementation of Text has changed. Closes apache#2786
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…P-17905 (Mark Bathori, reviewed by Stamatis Zampetakis) At the moment the problem does not appear cause Hive is still using 3.1.0 version. However, if Hadoop 3.4.0 (or greater) is in use the function generate incorrect results cause the underlying implementation of Text has changed. Closes apache#2786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After the application of HADOOP-17901 and HADOOP-17905 they changed the backing array increment logic which is causing issues in the UDFSpace class.
Why are the changes needed?
The previous
result.getBytes().lengthis returning incorrect size which is causing error in the result output. By changing this method call toresult.getLength()the size calculation is correct again any the original behaviour is restored.Example of the UDFSpace behaviour with the different method calls:
Note that the issue is only present with Hadoop version that contains HADOOP-17901 and HADOOP-17905.
Does this PR introduce any user-facing change?
No
How was this patch tested?
The change was tested on live cluster and also in the new qtest that was introduced in the scope of this patch.