HIVE-25862: Persist the time of last run of the initiator#2945
Merged
asinkovits merged 1 commit intoapache:masterfrom Jan 17, 2022
Merged
HIVE-25862: Persist the time of last run of the initiator#2945asinkovits merged 1 commit intoapache:masterfrom
asinkovits merged 1 commit intoapache:masterfrom
Conversation
deniskuzZ
reviewed
Jan 13, 2022
...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 13, 2022
...-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 13, 2022
...-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 13, 2022
...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jan 13, 2022
Member
deniskuzZ
left a comment
deniskuzZ
left a comment
There was a problem hiding this comment.
Other than minor comments it LGTM
Change-Id: Id49e0ef7c721585864b9831278ce40ad55313dc7
asinkovits
force-pushed
the
HIVE-25862
branch
from
61af8fb to
ea45a8e
Compare
deniskuzZ
approved these changes
Jan 13, 2022
kgyrtkirk
added
tests unstable
tests pending
tests failed
and removed
tests pending
tests unstable
tests failed
labels
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…ovits, reviewed by Denys Kuzmenko) Closes apache#2945
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…ovits, reviewed by Denys Kuzmenko) Closes apache#2945
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Store the last run timestamp in the MT_KEY2 column of the AUX table for the initiator, so that its persisted across restarts.
Why are the changes needed?
The time of last run is used as a filter when finding compaction candidates.
Because it's only stored in memory, we lose this filtering capability if the service restarts, so it would make sense to persist it.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual testing was done.