HIVE-26093 Deduplicate org.apache.hadoop.hive.metastore.annotation package-info.java #3168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@zabetak: Could you please take a look?
We still should fix the javadoc issues, but at least in the meantime we have a way to generate the javadoc |
zabetak
reviewed
Apr 7, 2022
Member
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
I had a quick look and left some small questions.
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
zabetak
reviewed
Apr 8, 2022
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-javadoc-plugin</artifactId> |
Member
There was a problem hiding this comment.
I think we should also fix the version of the maven-javadoc-plugin globally to avoid build warnings and things being broken when a newer version appears.
Contributor
Author
There was a problem hiding this comment.
Since the javadoc generation is a big mess ATM, I would suggest to keep it as it is, and if the tests are failing then we can decide what we want to do with them.
See also: #3185
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
kgyrtkirk
added
tests pending
tests failed
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
labels
zabetak
approved these changes
Apr 11, 2022
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…ckage-info.java (Peter Vary reviewed by Stamatis Zampetakis) (apache#3168)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…ckage-info.java (Peter Vary reviewed by Stamatis Zampetakis) (apache#3168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the source generation for org/apache/hadoop/hive.metastore/annotation/package-info.java
Why are the changes needed?
Javadoc generation failed during the release process
Does this PR introduce any user-facing change?
No
How was this patch tested?
Generating javadoc