HIVE-26129: Non blocking DROP CONNECTOR #3173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
changed the title
nrg4878
reviewed
Apr 11, 2022
Contributor
nrg4878
left a comment
nrg4878
left a comment
There was a problem hiding this comment.
Looks good to me other than a couple of minor issues.
|
|
||
| package org.apache.hadoop.hive.ql.ddl.dataconnector.drop; | ||
|
|
||
| import org.apache.hadoop.hive.conf.HiveConf; |
Contributor
There was a problem hiding this comment.
nit: Appears to be unnecessary import.
| import org.apache.hadoop.hive.ql.ddl.DDLWork; | ||
| import org.apache.hadoop.hive.ql.hooks.ReadEntity; | ||
| import org.apache.hadoop.hive.ql.hooks.WriteEntity; | ||
| import org.apache.hadoop.hive.ql.io.AcidUtils; |
Contributor
There was a problem hiding this comment.
nit: Appears to be unnecessary import
deniskuzZ
force-pushed
the
drop_data_connector
branch
from
4d5f9e8 to
f54a9f3
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…Naveen Gangam) Closes apache#3173
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…Naveen Gangam) Closes apache#3173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Neither DummyTxnManager nor DbTxnManageer acquire any locks with
DATACONNECTORtypeWhy are the changes needed?
Lockless reads functionality
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.