HIVE-26167: QueryStateMap in SessionState is not maintained correctly#3234
Merged
lcspinter merged 1 commit intoapache:masterfrom Apr 30, 2022
Merged
HIVE-26167: QueryStateMap in SessionState is not maintained correctly#3234lcspinter merged 1 commit intoapache:masterfrom
lcspinter merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
The patch looks good, but one question: when we send in a statement via SQL in the normaly way, where does the query state get initialized? |
Contributor
Author
It is initialized in the driver constructor. |
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
lcspinter
changed the title
pvary
reviewed
Apr 25, 2022
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
apache#3234) (Laszlo Pinter, reviewed by Peter Vary)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
apache#3234) (Laszlo Pinter, reviewed by Peter Vary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the current querystate object to SessionState's QueryStateMap if it's missing.
Why are the changes needed?
Many unit tests are initializing the driver object once, but reusing it for all the query executions in the whole test method. Since the queryStateMap in the SessionState is cleared after the first query execution, all subsequent queries will not be able to access the querystate through the SessionState.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test, unit test