HIVE-26182: Some improvements to make DPP more debuggable#3257
Merged
abstractdog merged 2 commits intoapache:masterfrom Jul 2, 2022
Merged
HIVE-26182: Some improvements to make DPP more debuggable#3257abstractdog merged 2 commits intoapache:masterfrom
abstractdog merged 2 commits intoapache:masterfrom
Conversation
rbalamohan
reviewed
Apr 29, 2022
| info.values.add(value); | ||
| partitionCount++; | ||
| } | ||
| LOG.info("Received {} partitions (source: {})", partitionCount, sourceName); |
Contributor
There was a problem hiding this comment.
LGTM. +1.
Minor comment before commit: It would be nice to include columnName in this line. (info.columnName).
rbalamohan
approved these changes
Apr 29, 2022
Contributor
rbalamohan
left a comment
rbalamohan
left a comment
There was a problem hiding this comment.
Left very minor comment, which can be fixed before commit.
LGTM. +1
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
thanks @rbalamohan for the review (somehow I missed your comment), pushing an addendum commit to this PR before merging |
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
… (Laszlo Bodor reviewed by Rajesh Balamohan)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
… (Laszlo Bodor reviewed by Rajesh Balamohan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?