add missing duplicates of join keys to RS schema#3504
Closed
kasakrisz wants to merge 3 commits intoapache:masterfrom
Closed
add missing duplicates of join keys to RS schema#3504kasakrisz wants to merge 3 commits intoapache:masterfrom
kasakrisz wants to merge 3 commits intoapache:masterfrom
Conversation
kgyrtkirk
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
amansinha100
reviewed
Aug 5, 2022
amansinha100
left a comment
amansinha100
left a comment
There was a problem hiding this comment.
Thanks for the PR. Is there a JIRA id for this ?
| return rsOp; | ||
| } | ||
|
|
||
| private void addJoinKeyToRowScema( |
There was a problem hiding this comment.
nit: spelling: RowSchema (missing 'h')
| if (exprBack != null) { | ||
| if (ExprNodeDescUtils.isConstant(exprBack)) { | ||
| int kindex = reduceKeysBack.indexOf(exprBack); | ||
| addJoinKeyToRowScema(outputRR, index, i, colInfo, nm, nm2, kindex); |
There was a problem hiding this comment.
Previously we were checking if kindex >= 0 before adding to the output row schema. We should check here as well.
| int kindex; | ||
| // joinKey may present multiple times, add the duplicates to the schema with different internal name | ||
| // join LU_CUSTOMER a16 | ||
| // on (a15.CUSTOMER_ID = a16.CUSTOMER_ID and pa11.CUSTOMER_ID = a16.CUSTOMER_ID) |
There was a problem hiding this comment.
For clarity, could you pls add the internal name that would be produced for the 2 occurrences of a16.CUSTOMER_ID ?
Also, the duplicate occurrences could be in a WHERE clause instead of ON clause ..can we verify if that case also works.
kasakrisz
force-pushed
the
master-mapjoin
branch
from
95e9bf9 to
6562694
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
Contributor
Author
|
Final patch: #3505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?