-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-23754: LLAP, Add LoggingHandler in ShuffleHandler pipeline for better debuggability #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
Outdated
Show resolved
Hide resolved
|
looks good, I'm always more than happy to see debugging features coming into the code |
…etter debuggability
|
Kudos, SonarCloud Quality Gate passed! |
after - hive.log Attached hive.log before and after adding Netty LoggingHandler. Here is one of the snippets with the LoggingHandler: 2022-11-21T09:14:00,478 INFO [TezTR-823713_1_2_2_0_0] tez.ReduceRecordProcessor: Waiting for ShuffleInputs to become ready |
…etter debuggability (apache#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor)
…etter debuggability (apache#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit cbaca73)
…etter debuggability (apache#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor)
…etter debuggability (apache#3669) (Dmitriy Fingerman reviewed by Laszlo Bodor)








What changes were proposed in this pull request?
Adding LoggingHandler in ShuffleHandler pipeline for better debuggability.
Why are the changes needed?
For corner case debugging, it will be helpful to understand when netty processed OPEN/BOUND/CLOSE/RECEIVED/CONNECTED events along with payload details.
Adding "LoggingHandler" in ChannelPipeline mode to help in debugging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pre-commit testing.