HIVE-26697: Create vectorized Hive DeleteFilter for Iceberg tables#3747
Merged
szlta merged 2 commits intoapache:masterfrom Nov 11, 2022
Merged
HIVE-26697: Create vectorized Hive DeleteFilter for Iceberg tables#3747szlta merged 2 commits intoapache:masterfrom
szlta merged 2 commits intoapache:masterfrom
Conversation
Change-Id: I7b81bdbedcf908ddb6b17e3de27b54183ca085b3
lcspinter
approved these changes
Nov 11, 2022
Contributor
lcspinter
left a comment
lcspinter
left a comment
There was a problem hiding this comment.
final +1 (pendig tests)
Change-Id: I1250527449a7f3e8c4f37ad80e38d9e635ea1452
|
Kudos, SonarCloud Quality Gate passed!
|
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…pache#3747) (Adam Szita, reviewed by Laszlo Pinter)
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Dec 29, 2022
…pache#3747) (Adam Szita, reviewed by Laszlo Pinter) (cherry picked from commit 8b48ce5)
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…pache#3747) (Adam Szita, reviewed by Laszlo Pinter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a DeleteFilter that changes an Iterable of VectorizedRowBatches in a way that whenever a new batch is seen in the next() method, we iterate its rows and apply the original Iceberg DeleteFilter on it. In VRBs we can utilize the selected array to mark rows as selected (not deleted), so essentially we're going to implement the markRowDeleted method.