-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27000: Improve the modularity of the *ColumnStatsMerger classes #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27000: Improve the modularity of the *ColumnStatsMerger classes #3997
Conversation
…or NDV estimator in ColumnStatsMergerTest
.../src/main/java/org/apache/hadoop/hive/metastore/columnstats/merge/DateColumnStatsMerger.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
LGTM, +1 |
|
@ayushtkn, if you have spare cycles maybe you can help get this in since it's been approved already? Thanks! |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will give a day before committing in case anyone else has comments
…3997). (Alessandro Solimando, reviewed by Ayush Saxena, Akshat Mathur)
|
And I messed up while committing :-( |
We never make mistakes only if we do nothing at all, you are very very active so it happens. On that note, thanks a lot for always helping out with reviews and merges, much appreciated Ayush! |
…pache#3997). (Alessandro Solimando, reviewed by Ayush Saxena)
…classes (apache#3997). (Alessandro Solimando, reviewed by Ayush Saxena)" This reverts commit 35b1518. Reverting to correct the commit message
…pache#3997). (Alessandro Solimando, reviewed by Ayush Saxena, Akshat Mathur)
…pache#3997). (Alessandro Solimando, reviewed by Ayush Saxena)
…classes (apache#3997). (Alessandro Solimando, reviewed by Ayush Saxena)" This reverts commit 35b1518. Reverting to correct the commit message
…pache#3997). (Alessandro Solimando, reviewed by Ayush Saxena, Akshat Mathur)








What changes were proposed in this pull request?
Improving the modularity of the *ColumnStatsMerger classes by introducing a common parent class and moving there all the shared code that is not depending on the data type.
Why are the changes needed?
Those classes host some complex merging logic that is copy-pasted into several classes, a problem that is bound to worsen as we add new (and more complex) statistics.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing and introduced unit-tests relevant for the change:
mvn test -Dtest.groups=org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest -Dtest='*ColumnStats*Test.java' -pl standalone-metastore/metastore-server