Skip to content

Conversation

@ggrossetie
Copy link
Contributor

@ggrossetie ggrossetie changed the title Typo KEQ_SEQ -> KEY_SEQ HIVE-20785: Typo KEQ_SEQ -> KEY_SEQ Oct 20, 2018
@ggrossetie
Copy link
Contributor Author

Is there anyone out there ? It's really a major issue with a one line fix... 🤔
Related JIRA issue: https://issues.apache.org/jira/browse/HIVE-20785

@ggrossetie
Copy link
Contributor Author

Friendly ping @prasanthj @pvary 😉

@prasanthj
Copy link
Contributor

lgtm, +1. @Mogztter Sorry just got back from vacation. Could you please upload a patch to HIVE-20785 to trigger precommit tests? Once the test passes I will get this committed.

@ggrossetie
Copy link
Contributor Author

@prasanthj No worries. I've uploaded a patch on JIRA but nothing happened...

@prasanthj
Copy link
Contributor

I can see your patch already running precommit tests https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/15347/parameters/

It can take about 1-2 hours for the test to complete and report gets posted automatically to JIRA.

@ggrossetie
Copy link
Contributor Author

@prasanthj The build is completed

@prasanthj
Copy link
Contributor

@Mogztter feel free to close this PR since the patch has been committed.

@ggrossetie
Copy link
Contributor Author

ggrossetie commented Dec 18, 2018

Ok thanks @prasanthj
Out of curiosity, you don't use GitHub to merge contribution ? Next time I should just create a JIRA ticket and upload a patch ?

@ggrossetie ggrossetie closed this Dec 18, 2018
@prasanthj
Copy link
Contributor

Yeah. Not yet. Our current test infra is only integrated with Jira to trigger integration tests. Github PR's only run build as of now and we use it as an alternative to review board for reviews. So yes hive is not there yet with full integration with github. Yes. Jira + Patch is still required for tests and committing patches. For reviews you can send PR or upload patch to review board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants