Skip to content

Conversation

@InvisibleProgrammer
Copy link
Contributor

This change removes Mockito dependency from the root pom.xml to be able to upgrade mockito on a module bases and it enables removing PowerMock.

Upstream conversation in the ticket: https://issues.apache.org/jira/browse/HIVE-27592

What changes were proposed in this pull request?

Remove Mockito and PowerMock from root pom.xml and define those dependencies in the projects that are using them.

Why are the changes needed?

To be able to remove PowerMock module-by-module.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

By running precommit tests.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@InvisibleProgrammer InvisibleProgrammer marked this pull request as ready for review August 11, 2023 12:21
@InvisibleProgrammer
Copy link
Contributor Author

Note: It helps to finish my other PR about PowerMock here: #3798

Copy link
Contributor

@veghlaci05 veghlaci05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veghlaci05 veghlaci05 merged commit d424769 into apache:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants