HIVE-20897 : TestJdbcDriver2#testSelectExecAsync2 fails with result set not present error #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et not present error
sankarh
reviewed
Nov 27, 2018
| private final OperationType opType; | ||
| private final TProtocolVersion protocol; | ||
| private boolean hasResultSet = false; | ||
| private boolean hasResultSetIsSet = false; |
Contributor
There was a problem hiding this comment.
Why do we need hasResultSetIsSet? isn't it enough to keep default as false for hasResultSet if it is null in OperationHandle?
Contributor
There was a problem hiding this comment.
ok got it... btw, can we use Boolean object instead of boolean primitive type for hasResultSet so that we can set it to null if not set. This will avoid extra variable hasResultSetIsSet.
…et not present error : review comment fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.