HIVE-27801: Exists subquery rewrite results in a wrong plan #4922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…zmenko, reviewed by Attila Turoczy, Ayush Saxena) Closes apache#4922
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…zmenko, reviewed by Attila Turoczy, Ayush Saxena) Closes apache#4922
deniskuzZ
added a commit
to deniskuzZ/hive
that referenced
this pull request
Jan 2, 2024
…zmenko, reviewed by Attila Turoczy, Ayush Saxena) Closes apache#4922
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…zmenko, reviewed by Attila Turoczy, Ayush Saxena) Closes apache#4922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In cases where different Rel nodes refer to the same correlation var, we avoid creating another correlation var and record the 'rel' using the same correlation.
SortedSetMultimap can't be used since it doesn't allow duplicates.
mapFieldAccessToCorVar.containsKey(fieldAccess)was never positive in previous versions of Calcite (1.16) since RexFieldAccess had no equals() and hashcode() defined.Why are the changes needed?
fixes plan after decorrelation
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=subquery_complex_correlation_predicates.q