HIVE-28015: Iceberg: Add identifier-field-ids support in Hive#5047
Merged
zhangbutao merged 2 commits intoapache:masterfrom Feb 21, 2024
Merged
HIVE-28015: Iceberg: Add identifier-field-ids support in Hive#5047zhangbutao merged 2 commits intoapache:masterfrom
zhangbutao merged 2 commits intoapache:masterfrom
Conversation
zhangbutao
commented
Jan 29, 2024
...ore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
Show resolved
Hide resolved
zhangbutao
force-pushed
the
HIVE-28015
branch
from
7b6ba81 to
c743b69
Compare
deniskuzZ
reviewed
Feb 8, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Outdated
Show resolved
Hide resolved
Member
|
@zhangbutao, PR looks good, some minor stuff |
Contributor
Author
Thanks for your review! I've been out recently. Will come back asap. 😀 |
zhangbutao
force-pushed
the
HIVE-28015
branch
from
c743b69 to
ebcfa35
Compare
|
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…#5047)(Butao Zhang, reviewed by Denys Kuzmenko)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
createiceberg table with identifier field using hive primary key syntax. Then other engine like Flink can do upsert( writing equality deletes) on the table created by hive.create table testprikeyice(id int primary key disable novalidate, name string) stored by iceberg;I will complete
alteradd/drop primary key in the following task if we think this change is good.BTW, in current hive code, we can not get primary key through
show create tablestatement, and this will make it inconvenient for users to check primary key in hive jdbc client(beeline). I think we can optimize theshow create tablein following task.Why are the changes needed?
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Added new UTs