HIVE-28311: Backward compatibility of java.sql.Date and java.sql.Timestamp in hive-serde#5287
Closed
wecharyu wants to merge 1 commit intoapache:masterfrom
Closed
HIVE-28311: Backward compatibility of java.sql.Date and java.sql.Timestamp in hive-serde#5287wecharyu wants to merge 1 commit intoapache:masterfrom
wecharyu wants to merge 1 commit intoapache:masterfrom
Conversation
…stamp in hive-serde
|
Contributor
Author
|
@zabetak @dengzhhu653 @zhangbutao could you pls review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
java.sql.Dateandjava.sql.Timestampobjects in JavaXXXObjectInspector.Why are the changes needed?
The old clients before HIVE-20007 convert date value to
java.sql.Dateand timestamp value tojava.sql.Timestamp, but the new HMS only accept internalDateandTimestampwhile deserialize the expressions, which would causeClassCastException.Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Add new unit test:
mvn test -Dtest.groups= -Dtest=org.apache.hadoop.hive.serde2.objectinspector.primitive.TestPrimitiveObjectInspectorUtils -pl :hive-serde