HIVE-28515: Iceberg: Concurrent queries fail during commit with ValidationException. #5438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simhadri-g
reviewed
Sep 10, 2024
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestOptimisticRetry.java
Show resolved
Hide resolved
simhadri-g
approved these changes
Sep 10, 2024
Member
simhadri-g
left a comment
simhadri-g
left a comment
There was a problem hiding this comment.
LGTM pending green test run.
|
jjiang037
pushed a commit
to jjiang037/hive_upstream
that referenced
this pull request
Sep 12, 2024
…ationException. (apache#5438). (Ayush Saxena, reviewed by Simhadri Govindappa)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Sep 14, 2024
…ationException. (apache#5438). (Ayush Saxena, reviewed by Simhadri Govindappa)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Sep 20, 2024
…ationException. (apache#5438). (Ayush Saxena, reviewed by Simhadri Govindappa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't fail when the retry strategy is write_conflict in case of a commit failure, but rather retry
Why are the changes needed?
To avoid query failures where multiple queries are running concurrently on the same table & writes on similar set of files
Does this PR introduce any user-facing change?
Yes, In case of concurrent queries with conflicting files, the query doesn't fail but rather retries.
Is the change a dependency upgrade?
No
How was this patch tested?
UT