HIVE-21679: Replicating a CTAS event creating an MM table fails.#617
HIVE-21679: Replicating a CTAS event creating an MM table fails.#617sankarh wants to merge 2 commits intoapache:masterfrom
Conversation
| // write id. | ||
| if ((dbName == null) || tableName.contains(".")) { | ||
| String[] names = Utilities.getDbTableName(tableName); | ||
| dbName = names[0]; |
There was a problem hiding this comment.
if table name does not contain '.' ..this may throw array out of bound exception
There was a problem hiding this comment.
If dbName is null, then we expect to have db.table in tableName. CreateTableDesc.toTable for reference.
There was a problem hiding this comment.
May be I will remove the dbname null check.
| throw new SemanticException("db name can not be null"); | ||
| } | ||
| if (dbName.contains(".") || ((tableName != null) && tableName.contains("."))) { | ||
| throw new SemanticException("Invalid DB or table name." + dbName + "::" |
There was a problem hiding this comment.
"::" can be printed if table name is not null
There was a problem hiding this comment.
This is fine. Having :: helps to find if DB is empty or table name is null/empty easily. No change.
|
|
||
| // Create a non-acid table and replicate it. | ||
| WarehouseInstance.Tuple bootStrapDump = primary.run("use " + primaryDbName) | ||
| .run("create table t1_nonacid (a int, b int)") |
There was a problem hiding this comment.
i think this test case is already there in test replication acid table incremental load ..just need to change the table property
There was a problem hiding this comment.
I think, it is better to have new test case here instead of editing incremental acid test suit which is already heavy.
There was a problem hiding this comment.
Ok, updating current test case and removing new one.
2 participants
No description provided.