Skip to content

Conversation

@zabetak
Copy link
Member

@zabetak zabetak commented Jan 14, 2026

Why are the changes needed?

To speed up all tests using a file-system backed Derby database by avoiding expensive I/O operations. More details under HIVE-29401.

Does this PR introduce any user-facing change?

No, this is a test only change.

How was this patch tested?

Picked randomly a few q files that use Derby and checked that property takes effect by searching in the derby.log file.

mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=jdbc_handler.q -Pitests -pl itests/qtest
grep -a "durability" itests/qtest/target/tmp/derby.log 
Warning: The database is booted with derby.system.durability=test. In this mode, it is possible that database may not be able to recover, committed transactions may be lost, database may be in an inconsistent state. Please use this mode only when these consequences are acceptable  
Warning: The database is booted with derby.system.durability=test. In this mode, it is possible that database may not be able to recover, committed transactions may be lost, database may be in an inconsistent state. Please use this mode only when these consequences are acceptable  

@abstractdog
Copy link
Contributor

abstractdog commented Jan 14, 2026

big +1, thanks @zabetak for this effort! small change, but how much headache before...
we don't rely on derby consistency at all in the event of e.g. JVM crashes (if it crashes, let it go), so this is a 100% safe way to boost our unit tests' performance, I wish we had found this option before

@sonarqubecloud
Copy link

@zabetak zabetak merged commit 8f73188 into apache:master Jan 15, 2026
4 checks passed
@zabetak zabetak deleted the HIVE-29401 branch January 15, 2026 08:22
@zabetak
Copy link
Member Author

zabetak commented Jan 15, 2026

Many thanks for the review @abstractdog and for all the underlying work on our internal ticket for getting down to this and discovering that I/O operations can be very expensive in certain settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants