HIVE-29474: DESCRIBE FORMATTED for columns produces wrong output when…

[tanishq-chugh]

… the column datatype is STRUCT

What changes were proposed in this pull request?

Fix DESCRIBE FORMATTED for STRUCT datatype columns output

Why are the changes needed?

Currently, when we have a table with STRUCT datatype column, running the DESCRIBE FORMATTED query on the particular STRUCT column produces wrong output,
For Exm:
CREATE TABLE tbl_t (id int, point STRUCT<x:INT, y:INT>);
DESCRIBE FORMATTED tbl_t point;

gives the following output:

Here as we can observe that the col_name & data_type are wrong & instead should be point & struct<x:int,y:int> respectively.

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

Manual Testing & Qtest

[soumyakanti3578]

HiveMetaStoreUtils#getFieldsFromDeserializer should be agnostic of where it was called from, so adding a boolean variable in its args is not ideal.

Also, I don't like the idea that we have to add false everywhere we are calling the method from, as the changes seem irrelevant, just to add true in a couple of places.

It seems we are running into this issue because the tableName in method getFieldsFromDeserializer is default.[tbl].point. This is then split into names:

    String[] names = tableName.split("\\.");
    String last_name = names[names.length - 1];
    for (int i = 2; i < names.length; i++) {

and since the length of names is 3, we go into the for loop to iterate through the fields of point.

You could probably just pass the colName instead of desc.getColumnPath() in:

Hive.getFieldsFromDeserializer(desc.getColumnPath(), deserializer, context.getConf()));

in DescTableOperation.java‎. This will force it to skip over the for loop as there will just be 1 item in names.

Probably you won't need to change anything anywhere else. Please try this and let's see if all the tests pass.

[soumyakanti3578]

Please look into the sonarqube issues too, as I think they are valid.

[soumyakanti3578]

I think you're missing a new line here.

[tanishq-chugh]

Addressed SonarQube issues in commit d05c394

Added new line in commit ce5bd65

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[soumyakanti3578]

LGTM. I will merge this soon.