HIVE-29513: Increase HikariCP connection timeout default from 30s to 60s#6381
Open
rtrivedi12 wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29513: Increase HikariCP connection timeout default from 30s to 60s#6381rtrivedi12 wants to merge 1 commit intoapache:masterfrom
rtrivedi12 wants to merge 1 commit intoapache:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set HikariCP connection timeout to an explicit default of 60 seconds (60,000 ms) in HikariCPDataSourceProvider, making it configurable via
hikaricp.connectionTimeoutproperty.Why are the changes needed?
MetaStore experiences connection timeout errors when database response is slow or during peak load, as HikariCP's implicit 30-second default is insufficient.
Does this PR introduce any user-facing change?
Yes. Connection timeout default changes from HikariCP's implicit 30 seconds to Hive's explicit 60 seconds. Users can override this by setting
hikaricp.connectionTimeoutinhive-site.xml.How was this patch tested?
Added/updated unit tests in TestDataSourceProviderFactory: